Skip to content

Removing bind so this works with externally defined replacements #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing bind so this works with externally defined replacements #31

wants to merge 1 commit into from

Conversation

@samuelmburu
Copy link

@samuelmburu samuelmburu commented Jul 12, 2018

I have a shared list of replacements that I share across build systems, by removing the bind(this) the replacements work otherwise I get the following error:

Module build failed: TypeError: repl.replacement.bind is not a function
    at Object.<anonymous> (/Users/samuelmburu/workspace/productivity/survata-com/node_modules/string-replace-webpack-plugin/loader.js:20:72)
    at Array.forEach (<anonymous>)
    at Object.module.exports (/Users/samuelmburu/workspace/productivity/survata-com/node_modules/string-replace-webpack-plugin/loader.js:19:34)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samuelmburu